Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 403 Error Page Aesthetics #592

Merged
merged 7 commits into from
Jan 22, 2025
Merged

Fix 403 Error Page Aesthetics #592

merged 7 commits into from
Jan 22, 2025

Conversation

JigyasuRajput
Copy link
Contributor

@JigyasuRajput JigyasuRajput commented Dec 17, 2024 •
edited
Loading

Cambios propuestos:

  • Fixed the 403 error page to match the site's aesthetics.

Temas tratados:

Pruebas realizadas:

  • Ran the tests successfully with no errors.
  • Tested on Ubuntu 20.04

Cómo probar los cambios:

  1. Join a company on the site.
  2. Manually visit the URL https://www.python.org.ar/empresas/agregar/ to confirm the 403 page is displayed with the updated aesthetics.

image

Gracias por contribuir con el proyecto.

Estamos pendiente de revisar los cambios propuestos.

facundobatista
facundobatista requested changes Dec 24, 2024
View reviewed changes
Copy link
Member

@facundobatista facundobatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks there are changes here that are also in other proposed PR?

Also please double check changes, there are some that are not really changing anything useful, thanks!

eduzen
eduzen requested changes Jan 4, 2025
View reviewed changes
joboffers/views.py Outdated Show resolved Hide resolved
joboffers/tests/test_models.py Outdated Show resolved Hide resolved
@JigyasuRajput JigyasuRajput changed the title Fix 403 Error Page Aesthetics and Ensure Consistent URL Generation Fix 403 Error Page Aesthetics Jan 4, 2025
@eduzen
Copy link
Member

eduzen commented Jan 20, 2025

It looks fine I think.

facundobatista
facundobatista approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@facundobatista facundobatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@eduzen eduzen merged commit 016fc93 into PyAr:master Jan 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduzen eduzen eduzen approved these changes

@facundobatista facundobatista facundobatista approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

403 cuando quiero agregar una empresa ya estando asociado a otra
3 participants
@JigyasuRajput @eduzen @facundobatista